score reels no longer activate chime on score reset. #1784
Conversation
|
| @@ -154,7 +157,8 @@ async def _advance_reel_if_position_does_not_match(self): | |||
| while self._destination_value != self.assumed_value: | |||
| self.machine.events.post('reel_{}_will_advance'.format(self.name)) | |||
| wait_ms = self.config['coil_inc'].pulse(max_wait_ms=500) | |||
| self.machine.events.post('reel_{}_advancing'.format(self.name)) | |||
| if not self._quiet: | |||
| self.machine.events.post('reel_{}_advancing'.format(self.name)) | |||
There was a problem hiding this comment.
This is a nice fix, but limited to your specific application. An alternative approach would be to post the event with an argument like reset: true to indicate whether the reel is resetting or not. This way there's still an event for people who want/need to know the advancement of the reel, and chimes can be made conditional on that argument to determine whether to chime or not.
| @@ -75,7 +75,7 @@ def chime(cls, chime, **kwargs): | |||
| del kwargs | |||
| chime.pulse() | |||
|
|
|||
| def set_value(self, value): | |||
| def set_value(self, value, quiet=False): | |||
There was a problem hiding this comment.
Aligned with my previous comment, changing the argument from quiet to is_reset will provide usecase-independent context and help future developers understand what's happening.
There was a problem hiding this comment.
Hello. Please could you help me ?
Everything starts from the score_reel_controller, that will call set_value() of ScoreReelGroup class in 3 situations:
- _game_starting
- _rotate_player
- score_change
If I understand correctly, ScoreReel would always 'post reel{}_advancing', with an extra boolean argument 'reset'.
Then we would modify the chime handler of ScoreReelGroup, that would not pulse if reset is True.
How do I retrieve the reset argument in chime method ? Is it in kwargs, or do I just add a reset arg after chime ?
There was a problem hiding this comment.
When you post an event, you can include kwargs like so:
self.machine.events.post(f'reel_{self.name}_advancing', is_reset=False)
And then in an event listener, you can make it conditional:
event_player:
reel_myreel_advancing{not is_reset}: play_chime
|
This is to avoid noise during score reset.