Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sphinxcontrib.cairosvgconverter #7

Closed
wants to merge 1 commit into from

Conversation

kohtala
Copy link
Contributor

@kohtala kohtala commented Mar 26, 2020

I found there is a lightweight cairosvg package for Python for SVG to PDF conversion.

This adds a module to use it for conversion.

I have a large activity diagram created with PlantUML. Currently on Ubuntu 18.04.4 LTS I get strangely scaled images with inkscape, rsvg-converter makes it huge and very slow (although other tools keep it small and fast). CairoSVG is fast, but unfortunately the diagrams don't have all lines in correct places. But CairoSVG is under active maintenance, so that may improve over time. I request adding support for it as an alternative to the others.

Copy link
Collaborator

@sephalon sephalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Please have a look at the review comments I made.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
sphinxcontrib/cairosvgconverter.py Outdated Show resolved Hide resolved
sphinxcontrib/cairosvgconverter.py Outdated Show resolved Hide resolved
sphinxcontrib/cairosvgconverter.py Outdated Show resolved Hide resolved
sphinxcontrib/cairosvgconverter.py Outdated Show resolved Hide resolved
sphinxcontrib/cairosvgconverter.py Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@kohtala
Copy link
Contributor Author

kohtala commented Apr 18, 2020

Thanks for review, and for pointing each place to update separately. The commit is now updated according to comments.

@sephalon
Copy link
Collaborator

Thanks, I made a few more minor changes and merged. Closed.

@sephalon sephalon closed this May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants