Add basic Korean support #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kimbyungnam, thanks for the PR. I guess this one is not easy. I usually C&P the stopwords into Google translator to check them, but here it gives me something like a weird story, in the end:/ Not sure how to check these stopwords. Also, please rebase the branch and add Korean extra dependencies into setup.py file and update TravisCI file accordingly, otherwise the tests will fail. |
kimbyungnam
force-pushed
the
korean_dev
branch
from
f1359c1 to
4528def
Compare
|
In Korean there are postpositional particle, which don`t have meaning. maybe it makes you feel weird when you check via Google translator. so i write down the references. if it is not enough i will find another way to check the stopwords. thank you!! |
korean stopwords references http://pydoc.net/lexrankr/0.1.5/lexrankr.lexrankr/ https://www.ranks.nl/stopwords/korean
kimbyungnam
force-pushed
the
korean_dev
branch
from
7ed8e64 to
47b7464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by using kkma in konlpy library, we add Korean sentence and word tokenizer. it requires jdk>=7