New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: actual_exception is NilClass when 'exception.cause' is nil. #601

Merged

mislav merged 2 commits into mislav:master from elengine:fix_exception_cause_none

Oct 8, 2019

Contributor

elengine commented Sep 14, 2019

This PR fixes a issue:
Status code is not 404 when 'WillPaginate::InvalidPage' is included in exception.

Reason:
Exception#cause return nil when previous exception is none.

https://ruby-doc.org/core-2.6/Exception.html#cause-method

elengine added 2 commits

September 14, 2019 19:20


          fix: actual_exception is NilClass when 'exception.cause' is nil.

938108b


          Avoid Rails 5 deprecation warning about original_exception

6fdbde4

mislav merged commit 5adf241 into mislav:master

Owner

mislav commented Oct 8, 2019

Thank you!

mislav mentioned this pull request

Serve a 404 for unnested InvalidPage exceptions #572

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet