Ensure PageNumber is serialized as JSON number

Fixes #603
mislav · Oct 15, 2019 · ab44416 · ab44416
1 parent cb60abe
commit ab44416
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/will_paginate/page_number.rb b/lib/will_paginate/page_number.rb
@@ -28,7 +28,7 @@ def to_i
       @value
     end
 
-    def_delegators :@value, :coerce, :==, :<=>, :to_s, :+, :-, :*, :/
+    def_delegators :@value, :coerce, :==, :<=>, :to_s, :+, :-, :*, :/, :to_json
 
     def inspect
       "#{@name} #{to_i}"

diff --git a/spec/page_number_spec.rb b/spec/page_number_spec.rb
@@ -1,5 +1,6 @@
 require 'spec_helper'
 require 'will_paginate/page_number'
+require 'json'
 
 describe WillPaginate::PageNumber do
   describe "valid" do
@@ -38,6 +39,14 @@ def num
     it "passes the Numeric=== type check" do |variable|
       (Numeric === num).should be
     end
+
+    it "fails the Numeric=== type check" do |variable|
+      (Integer === num).should_not be
+    end
+
+    it "serializes as JSON number" do
+      JSON.dump(page: num).should eq('{"page":12}')
+    end
   end
 
   describe "invalid" do