Error in Safari after mangling

[puzrin]

Mangler can produce the same name for named function & it's param. That cause error in Safary. Example:

Original:

N.wire.on('cmd:glyph_options', function gopt_dialog(event) {...});

After mangle:

e.wire.on("cmd:glyph_options", function i(i) {...});

That CAN be avoided, if compressor used, but:

• sometime compressor is not desireable
• i have to set unused: false due Very slow processing for minified files #321

Is it possible to fix?

PS. It seems, this bug already was reported in #179. There are more examples.

[mishoo]

The following code does not error out in Safari 6.0.5. Could it be that the issue was fixed?

(function(){
    "use strict";
    function x(x) {
        console.log(x);
    }
    x(10);
})();

I don't like the idea to cripple UglifyJS to work around browser bugs, though that's sometimes necessary. Not sure we should "fix" this one, any more opinions?

[puzrin]

If problem is in example - i'll spend time to find a better one. Current situation is, that one of #321 or #326 should be fixed for safe deploy on production sites.

1. We can't just send all safary users to hell. Safary is popular.
2. We can't wait 5+ minutes on server start, due slowdown on minified files
3. We can't expect, that developper will not try to process minified files. Because, in real projects some external vendor modules have no unminified sources. Manual uncompression will be a pain for mainenance.

[rvanvelzen]

What version of Safari are you running?

[puzrin]

Personally, i've tested in Safary 7, OSX. But here is confirmation for 6.1 too fontello/fontello#225 (don't pay anttention on alert on screenshot, it's caused by broken script).

[rvanvelzen]

@mishoo: I've confirmed that this happens only with anonymous functions.

This will give the aforementioned error:

(function(){
    "use strict";
    (function x(x) {
        console.log(x);
    })(10);
})();

[rvanvelzen]

I've just submitted a pull request with a fix that should do the trick. It isn't nice, but it seems to work. Could you please verify?