This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR replaces the TravisCI configuration (which has not run in over a year) with one for Github Actions. This retains essentially all the same pieces of what Travis was doing, though with tweaks to get things to work in the "GH actions" way (e.g. such as using coveralls workflow, vs the npm coveralls package). See https://github.com/MasterOdin/react-redux-loading-bar/actions/runs/7335355578/ for what this looks like, where it's hooked up to upload to https://coveralls.io/github/MasterOdin/react-redux-loading-bar.
One suggestion would be to drop the usage of
test:coveralls
where doing| coveralls
eats the test input, but instead usetest:coverage
(with--reporter=lcov
), and then usecoverallsapp/github-action
to upload the coverage report, as it gives you the full test output, as is the more "blessed" way to do this, and avoids having to know to setup theCOVERALLS_REPO_TOKEN
value.