Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] How do you make Connection in Notify more clickable range? #131

Closed
lyq-lin opened this issue Aug 5, 2024 · 3 comments · Fixed by #133
Closed

[Question] How do you make Connection in Notify more clickable range? #131

lyq-lin opened this issue Aug 5, 2024 · 3 comments · Fixed by #133
Assignees
Labels
question Further information is requested

Comments

@lyq-lin
Copy link

lyq-lin commented Aug 5, 2024

Hello, @miroiu . I'd like to make the Connection clickable wider in Notify. In other words, the range that can be clicked is larger than what is actually seen, is there a chance that it will be realized? I would appreciate it if you could provide ideas!

ex:
image

I've noticed that Connection in Notify has an animation that expands when selected. It might look something like this, but I need to broaden the range before I select, or rather, expand the range of options.

@lyq-lin lyq-lin added the question Further information is requested label Aug 5, 2024
@miroiu
Copy link
Owner

miroiu commented Aug 5, 2024

Hi @lyq-lin , I would like to implement this for the next release, but I can't do it before the second half of this month. The solution I'm thinking of is to draw the connection wire a second time but with a larger stroke thickness and a transparent brush. This will be configurable because not all projects need to interact with connection wires, and it may also decrease performance.

@lyq-lin
Copy link
Author

lyq-lin commented Aug 6, 2024

Hi @lyq-lin , I would like to implement this for the next release, but I can't do it before the second half of this month. The solution I'm thinking of is to draw the connection wire a second time but with a larger stroke thickness and a transparent brush. This will be configurable because not all projects need to interact with connection wires, and it may also decrease performance.

Maybe I should implement this section in OnRender, thanks for your help!

@lyq-lin lyq-lin closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2024
@miroiu miroiu reopened this Aug 16, 2024
@miroiu
Copy link
Owner

miroiu commented Aug 16, 2024

I created a PR to address this issue. #133

BAndysc added a commit to BAndysc/nodify-avalonia that referenced this issue Oct 24, 2024
* Release mouse capture on connector cancel due to KeyUp event

* Update CHANGELOG.md

* Bump version for release

* Port to Avalonia

* Fix warnings

* Update README.md

Add link to Avalonia port

* Fix: Zooming into nested editors should not zoom the parent editors

* Fix: Cancelling a pending connection via a hot key will no longer throw an exception

* Fix: Exceptions in UnscaleTransformConverter and UnscaleDoubleConverter

* Fix: Cannot use marquee selection and pan at the same time

* Fix: fixed selection clear on items collection reset

* Fix: Cannot use marquee selection inside comment nodes

* 5.2.0.1 release

* Reorder DataTemplates in calculator demo for easier Avalonia merges

* Fix: The selection rectangle stops updating when the cursor is outside the window

* Added BaseConnection.Orientation to allow vertical connections

* Updated changelog

* Fix: Mimic WPF's mouse capture behavior

* fix small spelling error in recently added dependency property

* split source/target orientation

* better control point if different orientations

* slight clarification in changelog

* Updated changelong

* Added directional arrows

* Fixed spelling issue

* Caluclate bezier connection tangent

* Added vertical nodes in playground app

* Minor adjustments

* Merge fix

* Update Avalonia to 11.1.0-beta2

* Allow changing editor gestures at runtime (miroiu#104)

Separated selection gestures for ItemContainer and GroupingNode from the NodifyEditor
Added new gesture types: AnyGesture, AllGestures, and NodifyGesture
Fixed a bug where the item container would incorrectly transition to the dragging state on mouse over

* Added Orientation to NodeInput and NodeOutput (miroiu#105)

* Added Orientation dependency property to NodeInput and NodeOutput

* Added the ability to animate directional arrows on connections (miroiu#106)

* Added DirectionalArrowsOffset dependency property to BaseConnection
Added StartAnimation and StopAnimation methods to BaseConnection

* Added Toggle connections animation button in playground app

* Prepare for release

* Allow changing editor gestures at runtime (miroiu#104)

Separated selection gestures for ItemContainer and GroupingNode from the NodifyEditor
Added new gesture types: AnyGesture, AllGestures, and NodifyGesture
Fixed a bug where the item container would incorrectly transition to the dragging state on mouse over

* Added Orientation to NodeInput and NodeOutput (miroiu#105)

* Added Orientation dependency property to NodeInput and NodeOutput

* Added the ability to animate directional arrows on connections (miroiu#106)

* Added DirectionalArrowsOffset dependency property to BaseConnection
Added StartAnimation and StopAnimation methods to BaseConnection

* Added Toggle connections animation button in playground app

* Prepare for release

* Post-merge fixes

* Update readme

* Fixed knot node binding errors in playground app

* fix bug can not access editor command (#17)

* fix bug can not access editor command

---------

Co-authored-by: Bartosz Korczynski <[email protected]>

* Fix: Can't resize grouping nodes

* Fix: Sticky Connections

* Fix: Don't open context menu when panning

* Add new built-in connection type: StepConnection (miroiu#109)

* Fix BaseConnection SplitEvent and DisconnectEvent not being raised if the corresponding command is null

* Fixed DecoratorContainer scaling with zoom when not referencing a theme in App.xaml

* Fixed wrong connector position for knot nodes when using step connection (miroiu#112)

* Sync documentation to wiki

* Update sync-docs.yml

* add chinese wiki docs (miroiu#114)

* Merge conflicts fix

* [Example] Add shapes drawing example application (miroiu#115)

* Add new example application

* Disable editing controls when the canvas is locked

* Draw shapes by click and drag

* Add ResizablePanel to resize shapes

* Update README.md

Add canvas app example

* NodifyObservableCollection: Avoid copying the list of items if there are no subscribers to removed or cleared events

* Bump version for release

* Update FAQ.md

* Improved Node customizability

* Added DataContext to ItemsSelectStartedCommand, ItemsSelectCompletedCommand, ItemsDragStartedCommand and ItemsDragCompletedCommand

* Fix containers at (0, 0) being selected when double clicking on the canvas

* Update changelog

* Update Connections-Overview.md

* Resolve merge conflicts

* Upgrade to Avalonia 11.1

* Fix CI

* Add a Minimap control to Nodify (miroiu#124)

* Added a Minimap control to Nodify

* Add  MaxViewportOffset and Zoom event

* Add ResizeToViewport

* Add playground settings

* Add IsReadOnly to minimap to allow disabling controls

* Add documentation

* Bump version for release

* Increase minimap colors contrast

* Resolve WPF merge conflicts

* Build fix

* Added a link to a live, browser demo

* Update the getting started section  miroiu#125

* Update README.md

Fix image link for Shapes app

* Add CuttingLine control to Nodify (miroiu#127)

* Added CuttingLine control to Nodify

* Bump version for release

* Update api reference

* Update README.md (#19)

Spent far too long going in circles with this one... 😄

* Add OutlineBrush and OutlineThickness to BaseConnection (miroiu#133)

Fixes miroiu#131

* Add IsAnimatingDirectionaArrows and DirectionalArrowsAnimationDuration dependency properties to BaseConnection (miroiu#135)

* Add the ability to select connections (miroiu#139)

* Add multi-select and support for custom connections

* Added CanSelectMultipleItems to NodifyEditor

* Added settings search box to playground app

* Fix Calculator context manu and converter issues.

* Update Avalonia version to 11.1.4

* Fix Calculator context menu

* Add support for ScrollViewer (miroiu#142)

* Implement IScrollInfo

* Bump version for release

* Merge commit 'efa15e00e859d4f756e87e8743994693844d759e' into avalonia_port

* Add support for ScrollViewer

---------

Co-authored-by: Emanuel Miroiu <[email protected]>
Co-authored-by: Hendrik Polczynski <[email protected]>
Co-authored-by: phamviethuy <[email protected]>
Co-authored-by: enheng? <[email protected]>
Co-authored-by: ArronDavies <[email protected]>
Co-authored-by: Mario Pintaric <[email protected]>
miroiu added a commit that referenced this issue Nov 25, 2024
* Update api reference

* Add OutlineBrush and OutlineThickness to BaseConnection (#133)

Fixes #131

* Add IsAnimatingDirectionaArrows and DirectionalArrowsAnimationDuration dependency properties to BaseConnection (#135)

* Add the ability to select connections (#139)

* Add multi-select and support for custom connections

* Added CanSelectMultipleItems to NodifyEditor

* Added settings search box to playground app

* Add support for ScrollViewer (#142)

* Implement IScrollInfo

* Bump version for release

* Add InputGroupStyle and OutputGroupStyle to Node (#145)

* Add InputGroupStyle and OutputGroupStyle to Node

* Add CornerRadius to Line, Circuit and Step connections (#149)

* Fix binding errors in example apps and window background in the StateMachine app

* Pan using mouse wheel (#147)

* Move all items relative to the cursor by performing a drag gesture (#150)

* Push items relative to the cursor

* Update changelog and api reference

* Upgrade to .NET 9

* Update github actions

* Add documentation comments to a few methods

* Fix ItemContainer borders not reacting to theme changes (#151)

* Update build.yml

* Bump version for release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants