Use sexp_of ppx and remove unnecessary t_of_sexp stubs #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
reviewed
Apr 20, 2021
|
thanks, I'll get to this soon. it looks good (see a minor comment above) |
Co-authored-by: Hannes Mehnert <[email protected]>
|
Sure, that change makes sense. Thanks for taking a look at this! |
hannesm
added a commit
to hannesm/ocaml-tls
that referenced
this pull request
Apr 22, 2021
hannesm
added a commit
to hannesm/ocaml-tls
that referenced
this pull request
Apr 22, 2021
hannesm
added a commit
to hannesm/ocaml-tls
that referenced
this pull request
Apr 22, 2021
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Apr 22, 2021
CHANGES: * Breaking: use deriving sexp_of instead of sexp. Constructing a state from a sexp has not been supported (lead to exception), and is now removed (mirleft/ocaml-tls#430 by @torinnd, continued in mirleft/ocaml-tls#431 by @hannesm) * Bugfix: TLS 1.3 client authentication with certificate, client side. This used to work accidentally before 0.13.0 changed the signature algorithms handling, now the right signature algorithm (as requested by server) is used. (mirleft/ocaml-tls#431 @hannesm, @talex5 reported mirage/capnp-rpc#228) * adapt to x509 0.13.0 and mirage-crypto-ec 0.10.0 changes (mirleft/ocaml-tls#431 @hannesm)
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Apr 22, 2021
CHANGES: * Breaking: use deriving sexp_of instead of sexp. Constructing a state from a sexp has not been supported (lead to exception), and is now removed (mirleft/ocaml-tls#430 by @torinnd, continued in mirleft/ocaml-tls#431 by @hannesm) * Bugfix: TLS 1.3 client authentication with certificate, client side. This used to work accidentally before 0.13.0 changed the signature algorithms handling, now the right signature algorithm (as requested by server) is used. (mirleft/ocaml-tls#431 @hannesm, @talex5 reported mirage/capnp-rpc#228) * adapt to x509 0.13.0 and mirage-crypto-ec 0.10.0 changes (mirleft/ocaml-tls#431 @hannesm)
hannesm
referenced
this pull request
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[@@deriving sexp_of] seems like the more appropriate ppx to use given many of the types in lib/ can't be deserialized.
This would avoid confusion like #398 where it's unclear if a state can be restored from an S-expression.