Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description and reason
Currently,
:plugins
option supports only:phoenix
. It would be nice to add some flexibility by supporting one arity function.In my case the project folder structure does not match with the Phoenix naming convention, i.e. instead of
app_web
I haveapp_api
. That prevents the predefined:phoenix
plugin to do its' magic. This PR will allow forplugins: [&MyApp.Credo.check_module_fIlename/1]
👷 Work done
Tasks
Additional notes
Consider passing module name in
:plugins
opt. This will follow the Open Closed principle, i.e.plugins: [CredoNaming.Check.Consistency.ModuleFilename.Plugins.Phoenix]
🎉 Result
Not needed
🦀 Dispatch
#dispatch/elixir