-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goodbye Travis and AppVeyor, welcome Actions! #19
Conversation
* Workflow based on `usethis::use_github_action("check-standard", save_as = "ci.yaml")`. * Triggered on any branch, full matrix of OS's and R versions. * Badge based on `usethis::use_github_actions_badge()`, link made specific to the R-CMD-check workflow.
* Same setup as for the former Travis CI.
* This works around the fact that, in certain circumstances, we cannot rely on errors propagating with proper `std::invalid_argument` class / error message. See also RcppCore/Rcpp#972
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I would vote for removing AppVeyor as well. But the PR is fine either way.
* Made redundant by the GH actions workflow (#14), covering Windows checks on several R versions.
Done with 3e304ae |
Note that the failure reported by the battery of checks is due to a tiny detected reduction in code coverage, which is not an issue and might be an artifact, as a second codecov check shows no changes. |
Closes #14.
The CI workflow setup can be reviewed, although this PR should be merged after including the fix to
macOS-latest (oldrel)
in #15 via PR #17.