Make MirageJS peer dependency #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cah-brian-gantzler
added
Dependencies
Comment on lines
-33
to
-44
| insertShutdownIntoDestroyApp: function () { | ||
| if (fs.existsSync('tests/helpers/destroy-app.js')) { | ||
| var shutdownText = | ||
| ' if (window.server) {\n window.server.shutdown();\n }'; | ||
| return this.insertIntoFile('tests/helpers/destroy-app.js', shutdownText, { | ||
| after: "run(application, 'destroy');\n", | ||
| }); | ||
| } | ||
| }, | ||
|
|
||
| afterInstall: function () { | ||
| return this.insertShutdownIntoDestroyApp(); |
There was a problem hiding this comment.
This was removed as destoy-app.js was removed in 3.0.0
Comment on lines
101
to
103
| "@ember/test-helpers": "*", | ||
| "ember-data": "*", | ||
| "ember-qunit": "*" | ||
| "ember-qunit": "*", |
There was a problem hiding this comment.
Should these be *?
|
Would you be opposed to adding Husky. I have it on my own apps so keep forgetting to run lint and prettier prior to submitting PRs :) |
|
This is a good change, without it people cannot reliably adopt the new pattern that is documented for 3.0 (importing directly from miragejs). |
SergeAstapov
removed
the
Dependencies
# Conflicts: # packages/ember-cli-mirage/package.json # test-packages/01-basic-app/package.json # test-packages/02-app-that-excludes-mirage/package.json
SergeAstapov
changed the title
SergeAstapov
approved these changes
Sep 13, 2023
francois2metz
pushed a commit
to francois2metz/ember-cli-mirage
that referenced
this pull request
Dec 19, 2023
Make MirageJS peer dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
MirageJSa peer dependency. This is a breaking change. Any existing applications usingember-cli-miragewill have to rerun the default blueprintember install ember-cli-mirageor addmiragejsto yourpackage.jsonmannually.Fixes: #2416