-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate miragejs re-exports from ember-cli-mirage/*
modules
#2256
Deprecate miragejs re-exports from ember-cli-mirage/*
modules
#2256
Conversation
4f72db3
to
297a7ca
Compare
Yea, Most these files will be able to be deleted in the breaking release |
I thought you had a PR merged that added the auto-import 2.x to the tests? Or is that still a work in progress |
I think you refer to https://github.com/miragejs/ember-cli-mirage/pull/2253/files where I updated |
Yes thats what I was referring to. But since it was merged I wondered why this failed the ember 4.x tests. I hadnt looked, thought it was auto import, now it looks like is |
@cah-briangantzler I've outlined the (IMO) safe plan for addon-docs upgrade in this comment, which is IMO orthogonal to the changes in this PR but still should bring us closer to the new [major] release and green CI. |
f388129
to
38efaeb
Compare
Since you have extracted a lot of the code to some methods, you might want to consider (in the future) creating an addon that supplies this re-export deprecating. I googled for a long time and didnt find any code to do it. So an addon that would provide this for others when they need it would be nice. |
47ec3c3
to
3fa675d
Compare
3fa675d
to
971ddb5
Compare
ember-cli-mirage/*
modules
I think this is fantastic work and sad that it will all go away when the deprecations are removed. I think that some of the code could be put in an addon to be used other addons that also need to deprecate their own exports. |
Thanks! I was thinking about making it generic but couldn't came up with any nice interface. I think some sort of searchable blog post would be helpful (this PR also should be indexed and searchable by Google and co). |
This is continuation for #2244.
As discussed with @cah-briangantzler, this is necessary for the next major release where
ember-cli-mirage
should become thiner Ember.sj glue to bringmiragejs
to the Ember world.Few more re-exports needs to be updated/deprecated but you should be able to grasp the direction this is heading.