build: only include used composable-helpers #2171
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this really needed? composable helpers is a dev dependency meaning it really only applies to the docs. This change would strip the unused helpers from the docs site, but really has no bearing on any app that includes mirage. |
|
@cah-briangantzler I guess it's not strictly needed, but since it also only affects the docs site, and make the payload a little smaller I'm still going to merge it :) |
Turbo87
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures the add-on
ember-composable-helpersto only include a specific set of helpers when the project is built.According to your HBS files, you only use the helper
sort-by:https://github.com/miragejs/ember-cli-mirage/search?l=handlebars