Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of calls to opam when using opam #79

Closed
wants to merge 3 commits into from

Conversation

kit-ty-kate
Copy link
Contributor

No description provided.

@kit-ty-kate kit-ty-kate changed the title OCaml 4.11 support Get rid of calls to opam when using opam Jun 16, 2020
@mato
Copy link
Contributor

mato commented Aug 26, 2020

@kit-ty-kate Sorry, lost track of what's happening here. As I understand it, ocaml-freestanding will work fine with OCaml 4.11 if I just update the availability, and indeed I just tested this, so I'll make that change in a separate PR to master.

The other changes here may or may not be required for OPAM 2.1?

@kit-ty-kate
Copy link
Contributor Author

Sorry for the lack of description on this PR. The previous version of ocaml-freestanding is already installable with OCaml 4.11 (see ocaml/opam-repository#16976). The only thing that this PR does is to make the build the tinyest bit faster and generally easier to install without opam.

OPAM 2.1 does not have to do anything wrt that, it was just a bug that has been fixed a while ago, but in my opinion it highlighted parts of packages that could be improved by making them the tiniest bit faster and more portable.

@mato
Copy link
Contributor

mato commented Oct 12, 2020

Ok, I get what this is supposed to do, but am going to close it for now; it introduces dependencies on a $PREFIX in the environment in ways that are not quite obvious, and in any case opam config var prefix takes about 0.013s to execute on my system.

@mato mato closed this Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants