conduit-lwt-unix: do not use directly the Ssl module #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead create an alias to the types needed in conduit_lwt_unix_ssl modules and use the alias. Signed-off-by: Pau Ruiz Safont <[email protected]>
Merged
1 task
|
thanks. |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Dec 15, 2022
…and conduit-async (6.1.0) CHANGES: done by @psafont in mirage/ocaml-conduit#417: * conduit-lwt-unix-ssl: allow users to create a client ssl_context and use it for any connections. This allows users to manage the lifecycle of the context. * conduit-lwt-unix-ssl: domain name verification can be disabled by users, it's enabled by default. The library returns an error when the hostname verification is turned on but it cannot be performed, this follows the TLS implementation. * conduit-lwt-unix-ssl: IP verification can be enabled by users, it's disabled by default. * conduit-lwt-unix-ssl: SNI is not sent when there isn't a domain name available * conduit-lwt-unix: avoid direct use of Ssl in conduit_lwt_unix (mirage/ocaml-conduit#418 @psafont)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead create an alias to the types needed in conduit_lwt_unix_ssl modules and use the alias.
This makes it possible to compile conduit-lwt-unix without openssl