Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ssh client support in conduit_mirage #296

Closed
wants to merge 1 commit into from

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Jun 27, 2019

please do not merge as is, this is on top of #290 (in this PR, only 5f1f30f is relevant)

the abstraction provided by conduit (client), loosely speaking: given an Uri.t provide a flow (with read/write/close) is not sufficient for ssh (FWIW, same is true for tls):

  • ssh needs (well, certainly you can use a password if you like) a private key for authentication, as well as an authenticator (usually a server fingerprint, but maybe as well a CA certificate), and a command to execute (this is not talking about the fully general ssh protocol, just the bits needed for git+ssh)
  • tls should accept an authenticator as well, also an optional client certificate

it is not clear to me how this fits / should fit into conduit:

  • atm i used an optional string(?config) and serialise/deserialise the command, private key seed, and authenticator -- this should be slightly better typed (sth like a ssh config)
  • unclear whether conduit should depend on the Tls.Config.client and Awa.Client.client directly or provide other structures

--> it is as well a bit unclear whether the goal of conduit is to be extensible in terms of transport protocols (i.e. should there be a conduit-mirage-tls, conduit-mirage-ssh)?

@hannesm hannesm changed the title [WIPssh client support in conduit_mirage [WIP] ssh client support in conduit_mirage Jun 27, 2019
@hannesm
Copy link
Member Author

hannesm commented Jun 27, 2019

sorry, i pressed enter to quickly, and just revised the description above.

@dinosaure dinosaure mentioned this pull request Sep 29, 2020
@dinosaure
Copy link
Member

Fixed by #311.

@dinosaure dinosaure closed this Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants