[WIP] ssh client support in conduit_mirage #296
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please do not merge as is, this is on top of #290 (in this PR, only 5f1f30f is relevant)
the abstraction provided by conduit (
client
), loosely speaking: given an Uri.t provide a flow (with read/write/close) is not sufficient for ssh (FWIW, same is true for tls):it is not clear to me how this fits / should fit into conduit:
string
(?config
) and serialise/deserialise the command, private key seed, and authenticator -- this should be slightly better typed (sth like a ssh config)--> it is as well a bit unclear whether the goal of conduit is to be extensible in terms of transport protocols (i.e. should there be a conduit-mirage-tls, conduit-mirage-ssh)?