Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation of the ssl backend #241

Merged
merged 3 commits into from
Sep 13, 2017
Merged

Fix compilation of the ssl backend #241

merged 3 commits into from
Sep 13, 2017

Conversation

samoht
Copy link
Member

@samoht samoht commented Sep 6, 2017

Also complete the matrix in the travis script so that future regressions will be caught faster.

This was referenced Sep 6, 2017
@rgrinberg
Copy link
Member

Is this a complete matrix though? We should also test the dummy modules i.e. whenever ssl or async_ssl are absent but conduit-lwt-unix or conduit-async are built.

@samoht
Copy link
Member Author

samoht commented Sep 6, 2017

yes, it's what DEPOPTS is supposed to do: first build without extra packages, then install the depopts. I'll double check that's it's indeed what happens.

@samoht
Copy link
Member Author

samoht commented Sep 6, 2017

So it's compiling both with and without the all the depopts. So I should probably try to alternate between tls/ssl/both. Also it seems that the tests are not run (very simple tests atm, just trying to link stuff together) so I am trying to fix that.

@samoht
Copy link
Member Author

samoht commented Sep 6, 2017

Tests are not running because we need a new release of ocaml-ci-scripts, which is now in progress: ocaml/ocaml-ci-scripts#179

@samoht
Copy link
Member Author

samoht commented Sep 13, 2017

So it appears that fixing the CI is much more involved that I was planning. Given that the current released version of conduit is broken, I'll focus now on making a new release - and I (or someone else) could fix the CI later.

@samoht samoht merged commit cd0e908 into mirage:master Sep 13, 2017
@samoht samoht deleted the ssl branch September 13, 2017 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants