Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mirage-conduit ocamlfind dependencies #232

Merged
merged 3 commits into from
Jul 25, 2017
Merged

Conversation

samoht
Copy link
Member

@samoht samoht commented Jul 25, 2017

Otherwise, we get:

File "_none_", line 1:
Error: No implementations provided for the following modules:
         Tls_mirage referenced from /Users/thomas/.opam/vpnkit/lib/mirage-conduit/conduit_mirage.cmxa(Conduit_mirage)

when linking

@samoht
Copy link
Member Author

samoht commented Jul 25, 2017

/cc @avsm with this patch I was able to update ocaml-git to latest conduit/cohttp.

@avsm
Copy link
Member

avsm commented Jul 25, 2017

Bah, we need a test case for this as well here -- is there a simple linkage test that would find this in the future, without pulling in the whole mirage configure dance?

@samoht
Copy link
Member Author

samoht commented Jul 25, 2017

@avsm: yea, just need to build some tests ;p I can add a very simple one, at least to check that linking is working fine.

@samoht
Copy link
Member Author

samoht commented Jul 25, 2017

Simple linking test pushed

@avsm avsm merged commit 1560569 into mirage:master Jul 25, 2017
@samoht samoht deleted the mirage branch July 26, 2017 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants