New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad access on string on `B64` module #23

Closed

dinosaure opened this issue Jan 14, 2019 · 0 comments · Fixed by #24

Member

dinosaure commented Jan 14, 2019

We retrieved an error when we computed some mails with mrmime and we got a bad access with the ocaml-base64, so we need to fix it.

The text was updated successfully, but these errors were encountered:

dinosaure mentioned this issue

New version of ocaml-base64 according to nocrypto's base64 implementation #24

Merged

dinosaure closed this as completed in #24

dinosaure added a commit to dinosaure/opam-repository that referenced this issue


          [new release] base64 (3.0.0)

97e02f2

CHANGES:

* Implemenation of Base64 according to RFC 2045 (available on base64.rfc2045)
* New implementation of Base64 according to RFC 4648 from nocrypto's implementation
* Fix bad access with `String.iter` on the old implementation of Base64 (@dinosaure, mirage/ocaml-base64#23)
* Check isomorphism between `encode` & `decode` function (@hannesm, @dinosaure, mirage/ocaml-base64#20)
* Add tests from RFC 3548 and from PHP impl. (@hannesm, @dinosaure, mirage/ocaml-base64#24)
* Add fuzzer on both implementations
 - check isomorphism
 - check bijection
 - check if `decode` does not raise any exception
* __break-api__, `B64` was renamed to `Base64` (@copy, @avsm, @dinosaure, mirage/ocaml-base64#17)
* __break-api__, `Base64.decode` and `Base64.encode` returns a result type instead to raise an exception (@hannesm, @dinosaure, mirage/ocaml-base64#21)
* __break-api__, Add `sub` type to avoid allocation to the end-user (@avsm, @dinosaure, mirage/ocaml-base64#24)
* __break-api__, Add `pad` argument on `decode` function to check if input is well-padded or not (@hannesm, @dinosaure, mirage/ocaml-base64#24)
* __break-api__, Add `off` and `len` optional arguments on `encode` & `decode` functions to compute a part of input (@cfcs, @dinosaure, mirage/ocaml-base64#24)
* Better performance (see mirage/ocaml-base64#24) (@dinosaure)
* Review of code by @cfcs (see mirage/ocaml-base64#24)

dinosaure mentioned this issue

[new release] base64 (3.0.0) ocaml/opam-repository#13297

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment