Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For DataKit, we apply these patches to ocaml-9p. I'm not sure we want them merged upstream in this form, but I'm making this PR to keep track of them:
When logging exceptions, include the 9p request that triggered it for debugging. Maybe the signature of
exn_converter
should be changed instead?While a connection is open, send a ping message (walk to
/
) every 30s. This avoids problems in some networks where TCP connections may silently stop working after a while unless there is traffic to keep the connection alive. It also reports these ping times as prometheus metrics. This should probably be optional.