irmin-pack: add lower_root config for lower layer #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metanivek
force-pushed
the
lower_layer_config
branch
from
6771e1b to
01217e4
Compare
Firobe
requested changes
Jan 25, 2023
metanivek
force-pushed
the
lower_layer_config
branch
2 times, most recently
from
4348639 to
99274c0
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2177 +/- ##
==========================================
- Coverage 68.07% 68.07% -0.01%
==========================================
Files 134 134
Lines 16161 16173 +12
==========================================
+ Hits 11001 11009 +8
- Misses 5160 5164 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
To give context in logs when this error is triggered.
metanivek
force-pushed
the
lower_layer_config
branch
from
99274c0 to
eaf725d
Compare
art-w
reviewed
Jan 30, 2023
| @@ -38,7 +38,7 @@ type base_error = | |||
| [ `Double_close | |||
| | `File_exists of string | |||
| | `Invalid_parent_directory | |||
| | `No_such_file_or_directory | |||
| | `No_such_file_or_directory of string | |||
There was a problem hiding this comment.
I'd like to take a look at all of our errors to decide which ones really deserve some extra context info. But, for a future PR. 😄
art-w
approved these changes
Jan 30, 2023
27 tasks
metanivek
added a commit
to metanivek/opam-repository
that referenced
this pull request
Apr 21, 2023
…min-pack, irmin-pack-tools, irmin-mirage, irmin-mirage-graphql, irmin-mirage-git, irmin-http, irmin-graphql, irmin-git, irmin-fs, irmin-containers, irmin-cli, irmin-chunk and irmin-bench (3.7.0)
CHANGES:
### Added
- **irmin**
- Add `Conf.pp` and `Conf.equal` to print and compare configuration values
(mirage/irmin#2227, @samoht)
- Add a `clear` optional arguments to all function that adds a new commit:
`Commit.v`, `set`, `set_tree`, `remove`, `test_and_set`,
`test_and_set_tree`, `test_set_and_get`, `test_set_and_get_tree`, `merge`,
`merge_tree` and `with_tree`. This new argument allows to control whether
the tree caches are cleared up after objects are exported to disk during
the commit. (mirage/irmin#2225, @samoht)
- **irmin-pack**
- Add configuration option, `lower_root`, to specify a path for archiving data
during a GC. (mirage/irmin#2177, @metanivek)
- Add `is_split_allowed` to check if a store allows split. (mirage/irmin#2175, @metanivek)
- Add `add_volume` to allow creating new empty volume in lower layer. (mirage/irmin#2188,
@metanivek)
- Add a `behaviour` function to the GC to check wether the GC will archive or
delete data. (mirage/irmin#2190, @Firobe)
- Add a migration on `open_rw` to move the data to the `lower_root` if
the configuration was enabled (mirage/irmin#2205, @art-w)
### Changed
- **irmin**
- Expose type equality for `Schema.Info` to avoid defining the `info` function
multiple times when using similar stores (mirage/irmin#2189, mirage/irmin#2193, @samoht)
- **irmin-pack**
- GC now changes its behaviour depending on the presence of a lower layer.
(mirage/irmin#2190, @Firobe)
- Split now raises an exception if it is not allowed. It is not allowed on
stores that do not allow GC. (mirage/irmin#2175, @metanivek)
- GC now supports stores imported V1/V2 stores, in presence of a lower layer
only. (mirage/irmin#2190, @art-w, @Firobe)
- Upgrade on-disk format to version 5. (mirage/irmin#2184, @metanivek)
- Archive to lower volume does not copy orphaned commits. (mirage/irmin#2215, @art-w)
### Fixed
- **irmin-pack**
- Unhandled exceptions in GC worker process are now reported as a failure
(mirage/irmin#2163, @metanivek)
- Fix the silent mode for the integrity checks. (mirage/irmin#2179, @icristescu)
- Fix file descriptor leak caused by `mmap`. (mirage/irmin#2232, @art-w)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the config key for the upcoming lower layer, with validation during
Repo.v.I didn't want to add a new error message just for an invalid
lower_rootvalue, and I also wanted good log message if the error occurs. To accomplish both, I am reusingNo_such_file_or_directoryand have added a string value for the file path. I think this also improves this error generally.