Stage Type.equal #1130
Merged
Stage Type.equal #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samoht
force-pushed
the
stagged-equal
branch
from
d8e2693 to
3aca45b
Compare
craigfe
reviewed
Nov 13, 2020
src/irmin-pack/IO.ml
Outdated
| @@ -106,7 +106,7 @@ module Unix : S = struct | |||
| mutable flushed : int64; | |||
| readonly : bool; | |||
| version : version; | |||
| buf : Buffer.t; | |||
| mutable buf : string list; | |||
There was a problem hiding this comment.
Looks like an unrelated change here. I got the impression that this ended up being bad for performance?
There was a problem hiding this comment.
hum yes indeed I though I had reverted this but that doesn't seem to be the case. Thanks for noticing!
samoht
force-pushed
the
stagged-equal
branch
from
3aca45b to
0e04bf7
Compare
samoht
force-pushed
the
stagged-equal
branch
from
0e04bf7 to
2c2bf85
Compare
|
I have removed the unrelated changes and added a CHANGELOG. Will probably consolidate this file later on anyway, as the generics have a new signature (which is a breaking change). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @craigfe