irmin: add Repo.iter #1128
Merged
irmin: add Repo.iter #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigfe
reviewed
Nov 13, 2020
| ?edge:(node -> node -> unit Lwt.t) -> | ||
| ?skip_nodes:(node -> bool Lwt.t) -> | ||
| ?skip_contents:(contents * metadata -> bool Lwt.t) -> | ||
| ?skip_node:(node -> bool Lwt.t) -> |
There was a problem hiding this comment.
GitHub won't let me suggest it, but need to s/skip_nodes/skip_node/ in comment below.
src/irmin/dot.ml
Outdated
| let vertex = Hashtbl.fold (fun k v acc -> (map k, v) :: acc) vertex [] in | ||
| let edges = List.map (fun (k, l, v) -> (map k, l, map v)) !edges in | ||
| let vertex = Hashtbl.fold (fun k v acc -> (k, v) :: acc) vertex [] in | ||
| let edges = List.map (fun (k, l, v) -> (k, l, v)) !edges in |
There was a problem hiding this comment.
Looks like we can remove this map altogether?
icristescu
approved these changes
Nov 13, 2020
It allows to iterate efficiently over the object graph.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows to iterate efficiently over the object graph.
Extracted from #1124