Add two events Pty/Set_env/Start_shell into the server #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinosaure
force-pushed
the
handle-pty-and-shell
branch
2 times, most recently
from
92d7ab5
to
43fc6fe
Compare
hannesm
reviewed
Mar 9, 2023
hannesm
reviewed
Mar 9, 2023
|
LGTM, minor nits in the comments. |
dinosaure
force-pushed
the
handle-pty-and-shell
branch
from
43fc6fe
to
a642ffe
Compare
|
I decided to upgrade the |
dinosaure
force-pushed
the
handle-pty-and-shell
branch
2 times, most recently
from
f6d39de
to
cadf744
Compare
dinosaure
force-pushed
the
handle-pty-and-shell
branch
from
cadf744
to
8aa0773
Compare
Unfortunately not yet, but I will :)
I prefer the awa-mirage style, but that's just a personal view, and I agree that a similar interface should be beneficial. |
|
I'm fine with this PR. I did not use the server API (yet). |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Mar 22, 2023
CHANGES: * server: be able to stop using a Lwt_switch.t (mirage/awa-ssh#52 @dinosaure) * server: add Pty/Set_env/Start_shell events (mirage/awa-ssh#53 @dinosaure) * client: support password authentication and keyboard-interactive (mirage/awa-ssh#51 @hannesm, reported by @dgjustice mirage/awa-ssh#31) * client: add NIST EC curves (mirage/awa-ssh#31 @hannesm) * client: try public key authenticaion only once (mirage/awa-ssh#50 @reynir @hannesm) * remove (partially implemented) hostbased authentication (mirage/awa-ssh#31 @hannesm) * replace deprecated Cstruct.copy by Cstruct.to_string (mirage/awa-ssh#53 @dinosaure) * remove ppx_cstruct and sexplib dependencies (mirage/awa-ssh#54 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change a bit the interface of
awa-mirageand give the ability to handle new events:Pty: when the window changeSet_env: when the client wants to set the local environmentShell: when the client requests a shell