Server update #30
Closed
Server update #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I followed the issue regarding calls to guard to a situation where Cipher is an AEAD algorithm and therefore the |
|
Thanks @palainp -- I'm the next 10 days away from my computer, and will try to review your changes early September. |
|
thanks, this looks fine. I merged it manually (and applied a minor style comment). |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Oct 28, 2021
CHANGES: * support rsa-sha2 and ed25519 in server code (mirage/awa-ssh#29 mirage/awa-ssh#30 @palainp) * awa_test_client: add --key argument (mirage/awa-ssh#28 @hannesm, suggested in mirage/awa-ssh#27 by @dgjustice @palainp) * Avoid deprecated Cstruct.len, avoid astring (@hannesm) * Drop rresult dependency (mirage/awa-ssh#34 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the server code. Currently able to connect to and from
OpenSSH_8.0p1.I still have a problem that I don't know how to deal with well: the
guard (is_keyed new_keys_*inlib/server.mlare still being triggered every time, so far I commented on them.I have not currently implemented
Hostkey.sexp_of_pubfor ED25519, the warning appears when using awa_test_client but does not seem to disturb communication too much.