Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPS support for Feed URLs #51

Merged
merged 5 commits into from
Jan 12, 2015
Merged

HTTPS support for Feed URLs #51

merged 5 commits into from
Jan 12, 2015

Conversation

leonklingele
Copy link
Contributor

Now that ShowRSS finally supports HTTPS connections, everyone should (be able to) use them.

@mipstian
Copy link
Owner

mipstian commented Jan 9, 2015

Thanks for this!

Two nitpicks:

  • Since it's no longer a prefix, can you rename the constant to end with Regex instead of PrefixRegex?
  • Could you use NSRegularExpression instead of NSPredicate?

@leonklingele
Copy link
Contributor Author

PR has been updated based on your feedback.

@mipstian
Copy link
Owner

Looks great, thanks!

mipstian pushed a commit that referenced this pull request Jan 12, 2015
Merge pull request #51 from leonklingele/https-support
4057936 
HTTPS support for Feed URLs
@mipstian mipstian merged commit 4057936 into mipstian:master Jan 12, 2015
mipstian pushed a commit that referenced this pull request Jun 9, 2023
Merge pull request #51 from leonklingele/https-support
908a49e 
HTTPS support for Feed URLs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonklingele @mipstian