Make sure a bad download script doesn't crash the whole app.

mipstian · Oct 22, 2021 · 209e6ba · 209e6ba
1 parent 05ffc8b
commit 209e6ba
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/Catch.xcodeproj/project.pbxproj b/Catch.xcodeproj/project.pbxproj
@@ -723,7 +723,7 @@
 				CODE_SIGN_IDENTITY = "";
 				COMBINE_HIDPI_IMAGES = YES;
 				COPY_PHASE_STRIP = NO;
-				CURRENT_PROJECT_VERSION = 783;
+				CURRENT_PROJECT_VERSION = 786;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;
 				ENABLE_TESTABILITY = YES;
 				FRAMEWORK_SEARCH_PATHS = (
@@ -788,7 +788,7 @@
 				CODE_SIGN_IDENTITY = "Mac Developer";
 				COMBINE_HIDPI_IMAGES = YES;
 				COPY_PHASE_STRIP = NO;
-				CURRENT_PROJECT_VERSION = 783;
+				CURRENT_PROJECT_VERSION = 786;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
 				ENABLE_NS_ASSERTIONS = NO;
 				ENABLE_STRICT_OBJC_MSGSEND = YES;

diff --git a/Sources/App/Scripts.swift b/Sources/App/Scripts.swift
@@ -20,7 +20,17 @@ extension Process {
           }
         }
       }
-      script.launch()
+
+      if #available(macOS 10.13, *) {
+        do {
+          try script.run()
+        } catch {
+          os_log("Couldn't run script: %{public}@", log: .main, type: .error, error.localizedDescription)
+          completion?(false)
+        }
+      } else {
+        script.launch()
+      }
     }
   }
 }