Fix workflow/yide #438
Closed
Fix workflow/yide #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyng
reviewed
Mar 10, 2021
| @@ -113,7 +113,7 @@ public TaskBuilder cloneBuilder() { | |||
| } | |||
|
|
|||
| public boolean shouldSchedule(Tick tick, OffsetDateTime currentTime) { | |||
| if(tick == SpecialTick.DIRECTLY_TICK){ | |||
| if(tick == SpecialTick.NULL){ | |||
| return true; | |||
| } | |||
There was a problem hiding this comment.
感觉你用SpecialTick.NULL来表达了两个意思：
- TaskRun对应的tick为空
- TaskRun是手动起调的
不要用一个对象来表达两个意思，除非这两个意思是同一个意思。
| @@ -153,9 +154,11 @@ public boolean statusUpdate(TaskAttemptMsg attemptMsg) { | |||
| TaskRunStatus taskRunStatus = attemptMsg.getTaskRunStatus(); | |||
| if (taskRunStatus.isFinished()) { | |||
| if (workerPool.containsKey(attemptMsg.getTaskAttemptId())) { | |||
| logger.info("taskAttemptId = {} going to release", attemptMsg.getTaskAttemptId()); | |||
| queueManage.release(attemptMsg.getQueueName()); | ||
| } | ||
| workerPool.remove(attemptMsg.getTaskAttemptId()); | ||
| logger.info("remove taskAttemptId = {} from worker pool", attemptMsg.getTaskAttemptId()); |
| } | ||
| try { |
shikimoe
force-pushed
the
FIX-workflow/yide
branch
from
d28d26f to
405a136
Compare
fix add log
shikimoe
force-pushed
the
FIX-workflow/yide
branch
from
405a136 to
7e17925
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#435