Fix worker timeout/yide #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shikimoe
force-pushed
the
FIX-worker-timeout/yide
branch
2 times, most recently
from
3c73b22 to
da8035f
Compare
fix bug
shikimoe
force-pushed
the
FIX-worker-timeout/yide
branch
from
da8035f to
6bda833
Compare
dyng
reviewed
Jan 18, 2021
| submit(taskAttempt, true); | ||
| //kill worker when worker time out | ||
| if (workerPool.containsKey(taskAttemptId)) { | ||
| Worker worker = workerFactory.getWorker(workerPool.get(taskAttemptId)); |
| Worker worker = workerFactory.getWorker(workerPool.get(taskAttemptId)); | ||
| worker.shutdown(); | ||
| workerPool.remove(taskAttemptId); | ||
| workerToken.release(); |
There was a problem hiding this comment.
像这种顺序做的步骤，需要考虑其中任意一步出错时，是否会导致不一致等问题。
shikimoe
force-pushed
the
FIX-worker-timeout/yide
branch
from
d2861fc to
617c5f6
Compare
guofan1991
pushed a commit
that referenced
this pull request
Jun 28, 2021
* fix kill worker fix bug * add log
steven-hyp
pushed a commit
that referenced
this pull request
Dec 30, 2021
* fix kill worker fix bug * add log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#368