Refactor/wallet generic signer #1783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OBorce
commented
Jun 18, 2024
•
OBorce
commented
- add a generic signer provider for creating a software or a hardware signer
- make account key chain generic to allow using it with and without a VRF keychain
- add an implementation for the trezor signer
- copy auto generated trezor client to communicate with a connected trezor device
- add new hardware-wallet option when creating and opening a wallet in the CLI and RPC wallet commands
OBorce
force-pushed
the
refactor/wallet-generic-signer
branch
from
e1f4596 to
37b71b9
Compare
OBorce
force-pushed
the
refactor/wallet-generic-signer
branch
6 times, most recently
from
626b7d1 to
fb2af0d
Compare
OBorce
commented
Aug 1, 2024
OBorce
commented
Aug 1, 2024
azarovh
reviewed
Aug 5, 2024
OBorce
force-pushed
the
refactor/wallet-generic-signer
branch
from
726bb45 to
855cfce
Compare
azarovh
reviewed
Aug 6, 2024
ImplOfAnImpl
approved these changes
Aug 7, 2024
OBorce
force-pushed
the
refactor/wallet-generic-signer
branch
2 times, most recently
from
1cd8110 to
c23f38d
Compare
azarovh
reviewed
Aug 24, 2024
OBorce
force-pushed
the
refactor/wallet-generic-signer
branch
from
c23f38d to
4824da8
Compare
OBorce
force-pushed
the
refactor/wallet-generic-signer
branch
4 times, most recently
from
6c3d058 to
037f258
Compare
azarovh
reviewed
Oct 7, 2024
azarovh
reviewed
Oct 7, 2024
azarovh
reviewed
Oct 8, 2024
| assert!(!devices.is_empty()); | ||
| let client = devices.pop().unwrap().connect().unwrap(); | ||
|
|
||
| let mut signer = TrezorSigner::new(chain_config.clone(), Arc::new(Mutex::new(client))); |
There was a problem hiding this comment.
- There should be some negative cases: where trezor failed to sign inputs with unknown keys or something like that.
- How does device become aware of private keys? I see that at the beginning of the test a key chain is created from mnemonic, but how trezor is related to that I don't understand (like initialising it with test mnemonic of something)
There was a problem hiding this comment.
ok I keep forgetting that this is manual test. So basically you have to recover a wallet from test mnemonic right?
OBorce
force-pushed
the
refactor/wallet-generic-signer
branch
from
48716c3 to
67609d5
Compare
OBorce
force-pushed
the
refactor/wallet-generic-signer
branch
from
67609d5 to
220ace1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.