Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace reject with resolve #610

Merged
merged 1 commit into from
May 28, 2023
Merged

Replace reject with resolve #610

merged 1 commit into from
May 28, 2023

Conversation

nilslindemann
Copy link
Contributor

No description provided.

@nilslindemann
Replace reject with resolve
e06bdb3 
Pressing the cancel button in a `Window.confirm()` will now not longer log an `Uncaught (in promise)` error to the console.

Related: mint-lang#609
@Sija Sija added the bug Something isn't working label May 28, 2023
@Sija Sija added this to the 0.19.0 milestone May 28, 2023
@Sija Sija added the stdlib Standard library related label May 28, 2023
@gdotdesign gdotdesign merged commit 3afae26 into mint-lang:master May 28, 2023
@nilslindemann
Copy link
Contributor Author

Thank you

@nilslindemann nilslindemann deleted the replace-reject-with-resolve branch May 28, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija approved these changes

Assignees
No one assigned
Labels
bug Something isn't working stdlib Standard library related
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nilslindemann @Sija @gdotdesign