LSP: Refactor definition to be similar to hover feature #595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately it's a little hard to see the actual change in this PR between all the red and green, so hopefully some description helps.
After understanding how the hover implementation works a little better, I've refactored the definition code to be more in line with it.
The biggest change is that I have reverted which nodes we track (see
track: false
everywhere), so we are no longer tracking more specific nodes such as component names etcInstead, there is a new method
cursor_intersects?
which can be used to check if a node is currently being hovered over. We can use this to exit early when trying to find the definition for a "higher level" node.e.g.
This removes the need for
StackReader
, as that was mostly used to find the reverse ("higher level" nodes from more specific ones)I've implemented some more of the easier "Go to Definitions" (for a separate PR for ease of review!) and it doesn't seem any more difficult to implement using this method.