Update Ast::Constant to use an Ast::Variable for its name
#594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
May 5, 2023
Sija
approved these changes
May 5, 2023
Sija
reviewed
May 5, 2023
gdotdesign
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
Ast::Constantto use anAst::Variablefor its name, rather than a string. This will be useful for future changes to the language server.Unfortunately, similar to the recent
Ast::TypeIdchange, it includes a lot of.value's, although there were a couple of places where I didn't seem to need to add it such as in the formatter.This PR also fixes a bug where some invalid constants were allowed, notably ones that start with a number or underscore. (e.g
_CONSTANT,1CONSTANT)