Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper exit code for the formatting command. #586

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Use proper exit code for the formatting command. #586

merged 1 commit into from
Apr 26, 2023

Conversation

gdotdesign
Copy link
Member

  • If formatted successfully exit with 0
  • If there is an error exit with 1
  • If there are not formatted files when using --check exit with 1
  • Properly print error when formatting via standard input

Should fix #548

@gdotdesign
Use proper exit code for the formatting command.
0a43e38 
- If formatted successfully exit with `0`
- If there is an error exit with `1`
- If there are not formatted files when using `--check` exit with `1`
- Properly print error when formatting via standard input
@gdotdesign gdotdesign added bug Something isn't working tooling Tooling related feature (formatter, documentation, production builder) labels Apr 26, 2023
@gdotdesign gdotdesign added this to the 0.18.0 milestone Apr 26, 2023
@gdotdesign gdotdesign requested a review from Sija April 26, 2023 12:52
@gdotdesign gdotdesign self-assigned this Apr 26, 2023
@gdotdesign gdotdesign linked an issue Apr 26, 2023 that may be closed by this pull request
mint format some_file.mint should return code 0 if no syntax error regardless if some_file.mint if changed. #548
Closed
@gdotdesign gdotdesign merged commit 776d5a6 into master Apr 26, 2023
@gdotdesign gdotdesign deleted the 548-mint-format-some_filemint-should-return-code-0-if-no-syntax-error-regardless-if-some_filemint-if-changed branch April 26, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija approved these changes

Assignees

@gdotdesign gdotdesign

Labels
bug Something isn't working tooling Tooling related feature (formatter, documentation, production builder)
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.

mint format some_file.mint should return code 0 if no syntax error regardless if some_file.mint if changed.
2 participants
@gdotdesign @Sija