-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for CSS at rules #238
Conversation
I believe interpolations should be allowed. That might come handy when specifying paths prefixes and such. |
|
That's exactly my point since you'd use these for defining paths prefixes to the assets (think CDN for instance). |
That would be great, but it's not trivial to implement. Actually it's technically impossible right now because dynamic properties are converted into CSS variables and I don't think they work in |
Wait, so interpolations are converted to CSS variables? Aren't they compiled into the resulting string? |
They are converted to CSS variables ➡️ https://github.com/mint-lang/mint/blob/master/spec/compilers/css_definition it's the most efficient way of making them dynamic and the only way to support them in sub selectors and pseudo elements. Also all definitions inside a |
Oh, I see. It makes sense then 👍 |
This PR implements support for the
@font-face
,@keyframes
and@supports
CSS rules.@font-face
It will compile into separate
@font-face
rules, sub selectors and interpolations are not allowed.@keyframes
It will compile into separate
@keyframes
rules, sub selectors are not allowed, interpolations are allowed.@supports
It works exactly like
@media
, interpolations and nested selectors are allowed.