Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and streamline capability handling #51

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
SA fix
uuf6429 committed Nov 21, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 024c979b8e593f5a11cc0bbbd94f003117f69fb5
3 changes: 3 additions & 0 deletions tests/Custom/CapabilityTest.php
Original file line number Diff line number Diff line change
@@ -86,7 +86,10 @@
*/
private function createDriverExposingCapabilities(string $browserName, array $desiredCapabilities = []): WebdriverClassicDriver
{
return new class($browserName, $desiredCapabilities) extends WebdriverClassicDriver {

Check failure on line 89 in tests/Custom/CapabilityTest.php

GitHub Actions / Static analysis

Method Mink\WebdriverClassicDriver\Tests\Custom\CapabilityTest::createDriverExposingCapabilities() should return Mink\WebdriverClassicDriver\WebdriverClassicDriver&object{capabilities: array<string, mixed>} but returns class@anonymous/tests/Custom/CapabilityTest.php:89.

Check failure on line 89 in tests/Custom/CapabilityTest.php

GitHub Actions / Static analysis

Method Mink\WebdriverClassicDriver\Tests\Custom\CapabilityTest::createDriverExposingCapabilities() should return Mink\WebdriverClassicDriver\WebdriverClassicDriver&object{capabilities: array<string, mixed>} but returns class@anonymous/tests/Custom/CapabilityTest.php:89.
/**
* @var null|array<string, mixed>
*/
public ?array $capabilities = null;

public function __construct(string $browserName, array $desiredCapabilities)