Wrap WebDriver exception about failed to load page into DriverException #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
============================================
+ Coverage 81.76% 84.21% +2.44%
- Complexity 191 194 +3
============================================
Files 1 1
Lines 488 494 +6
============================================
+ Hits 399 416 +17
+ Misses 89 78 -11 ☔ View full report in Codecov by Sentry. |
uuf6429
requested changes
Nov 2, 2024
aik099
force-pushed
the
page-load-timeout-exception-fix
branch
from
d9f59c1 to
c9a3b29
Compare
|
@uuf6429 , you can safely merge this PR if no other discussable topics are left. |
uuf6429
reviewed
Nov 2, 2024
Adjustments per review
aik099
force-pushed
the
page-load-timeout-exception-fix
branch
from
c9a3b29 to
4bacd30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap WebDriver's
TimeoutExceptionandScriptTimeoutExceptionexceptions intoDriverException, when the page wasn't opened due topagetimeout being met.P.S.
Based on minkphp/MinkSelenium2Driver#400 .