Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specify frame index in the "switchToIFrame" driver method #11

Closed
wants to merge 2 commits into from

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Feb 22, 2024

See minkphp/Mink#866 (PR 4 of 4)

Closes #8 , but must not be merged before other PRs in above mentioned discussion.

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a116f9) 82.88% compared to head (541f367) 82.88%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #11   +/-   ##
=========================================
  Coverage     82.88%   82.88%           
- Complexity      191      192    +1     
=========================================
  Files             1        1           
  Lines           479      479           
=========================================
  Hits            397      397           
  Misses           82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uuf6429 uuf6429 self-requested a review February 22, 2024 11:16
@aik099 aik099 requested a review from stof February 22, 2024 14:24
@aik099
Copy link
Member Author

aik099 commented Feb 23, 2024

Closing as per minkphp/Mink#866 (comment) .

@aik099 aik099 closed this Feb 23, 2024
@aik099 aik099 deleted the frame-switching-by-index branch February 23, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support switching to frame by index
2 participants