Minor doc review #79
Merged
Minor doc review #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Aug 21, 2017
| @@ -43,7 +43,7 @@ one single container object: | |||
|
|
|||
| .. note:: | |||
|
|
|||
| Mink will even lazy-start your sessions when needed (on first ``getSession()`` | |||
| Mink will even lazy-start your sessions when needed (on the first ``getSession()`` | |||
There was a problem hiding this comment.
actually, this doc is outdated. The Mink class does not ever start session anymore. It is a simple registry. Sessions themselves are now starting automatically when you visit a page for the first time.
There was a problem hiding this comment.
"real" doc content updates can easily be done in separate PRs. I have not attempted to check the truth of the statements, just fixed up some grammar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
various little bits of wording enhancement while I am reading.