Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Syn to 0.15.0 #333

Closed
wants to merge 1 commit into from
Closed

Update Syn to 0.15.0 #333

wants to merge 1 commit into from

Conversation

zrpnr
Copy link

@zrpnr zrpnr commented May 12, 2021

The Syn library has been under active development, and the current release is 0.15.0. MinkSelenium2Driver uses 0.0.3 currently.
In 0.15.0 there was a fix for the deprecated which property.
bitovi/syn#180

This affects any sites that are running tests with keyPress events if, for example- they use the latest jQuery 3.6.0 that removed a shim for this property.
jquery/jquery#4765

There was discussion about updating Syn in:

The minified js in this PR comes from the v0.15.0 tag of https://github.com/bitovi/syn
I added

options: {
  minify: true
},

to the export command in build.js and ran npm run build to produce dist/global/syn.js

In Selenium2Driver.php updated Syn to syn and updated the trigger function since the order of arguments has changed.

Copy link
Member

@aik099 aik099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zrpnr , please make sure tests are passing. Right now they're not.

@mvorisek
Copy link
Contributor

mvorisek commented Mar 1, 2023

@aik099 #358 was merged, let's close this PR

@aik099
Copy link
Member

aik099 commented Mar 1, 2023

Closing in favor of #358 .

@aik099 aik099 closed this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants