Fixed unwanted trailing tab in chrome 53 #244
Conversation
| } | ||
|
|
||
| $element->postValue(array('value' => array($value))); | ||
| $this->blur($xpath); |
There was a problem hiding this comment.
The change event should be fired instead of blur to make tests pass.
|
Also don't send PR from |
|
One test still fails. However I'm unsure if this is related to made changes or just to Firefox version updated on Travis CI, that doesn't play nice with Selenium Driver version that is used. |
|
For me latest stable Selenium Driver (2.53.0) + latest stable Firefox (48.0.1) doesn't work at all. When running test suite on Chrome I'm getting same |
|
I've created #245 issue for that failing test because it's not related. |
|
Otherwise change looks good if it solves problem you're having in both Chrome and Firefox. |
|
Faced with the same problem on my current project. This solution works for me in Chrome 53.0.2785.116 (64-bit). |
|
The build failure is due different problem described in #245. Otherwise tests are passing and I think this one is ready to be merged. |
|
Thanks @adorin , merging. |
this is needed to get this PR in minkphp/MinkSelenium2Driver#244 That fixes an issue with typing into autocomplete boxes
need to get this PR in: minkphp/MinkSelenium2Driver#244 It fixes an issue with typing into autocomplete boxes
need to get this PR in: minkphp/MinkSelenium2Driver#244 It fixes an issue with typing into autocomplete boxes
Closes #243