Merge pull request #278 from stof/fix_tests

Rewrite the capability test to be compatible with lazy-starting
minkphp · Oct 3, 2018 · d28b505 · d28b505
2 parents f4efaf5 + 7fa8a11
commit d28b505
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/tests/Custom/DesiredCapabilitiesTest.php b/tests/Custom/DesiredCapabilitiesTest.php
@@ -44,7 +44,9 @@ public function testSetDesiredCapabilities()
             'deviceType'        => 'tablet',
             'selenium-version'  => '2.45.0'
         );
-        $driver = $this->getSession()->getDriver();
+        $session = $this->getSession();
+        $session->start();
+        $driver = $session->getDriver();
         $driver->setDesiredCapabilities($caps);
     }
-}
+}
diff --git a/tests/Custom/WebDriverTest.php b/tests/Custom/WebDriverTest.php
@@ -9,8 +9,10 @@ class WebDriverTest extends TestCase
 {
     public function testGetWebDriverSessionId()
     {
+        $session = $this->getSession();
+        $session->start();
         /** @var Selenium2Driver $driver */
-        $driver = $this->getSession()->getDriver();
+        $driver = $session->getDriver();
         $this->assertNotEmpty($driver->getWebDriverSessionId(), 'Started session has an ID');
 
         $driver = new Selenium2Driver();

diff --git a/tests/Custom/WindowNameTest.php b/tests/Custom/WindowNameTest.php
@@ -11,6 +11,7 @@ class WindowNameTest extends TestCase
     public function testPatternGetWindowNames()
     {
         $session = $this->getSession();
+        $session->start();
 
         $windowNames = $session->getWindowNames();
         $this->assertArrayHasKey(0, $windowNames);
@@ -23,6 +24,7 @@ public function testPatternGetWindowNames()
     public function testGetWindowName()
     {
         $session = $this->getSession();
+        $session->start();
 
         $this->assertRegExp(self::WINDOW_NAME_REGEXP, $session->getWindowName());
     }