Also test on Selenium 3

minkphp · Jun 29, 2024 · a2f3652 · a2f3652
1 parent 897e7d7
commit a2f3652
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -38,11 +38,15 @@ jobs:
       - run: vendor/bin/phpstan analyze
 
   tests:
-    name: Tests
+    name: "Tests (PHP ${{ matrix.php }}, Selenium ${{ matrix.selenium_version }})"
     runs-on: ubuntu-20.04
     strategy:
       matrix:
+        selenium_version: [ '2.53.1' ]
         php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3' ]
+        include:
+          - selenium_version: '3.141.59'
+            php: '8.3'
       fail-fast: false
 
     steps:
@@ -71,7 +75,7 @@ jobs:
 
       - name: Start Selenium
         run: |
-          docker run --net host --name selenium --volume /dev/shm:/dev/shm --shm-size 2g selenium/standalone-firefox:2.53.1 &> ./logs/selenium.log &
+          docker run --net host --name selenium --volume /dev/shm:/dev/shm --shm-size 2g selenium/standalone-firefox:${{ matrix.selenium_version }} &> ./logs/selenium.log &
 
       - name: Wait for browser & PHP to start
         run: |
@@ -91,6 +95,6 @@ jobs:
         if: ${{ failure() }}
         uses: actions/upload-artifact@v2
         with:
-          name: logs_php-${{ matrix.php }}
+          name: logs_php-${{ matrix.php }}_selenium-${{ matrix.selenium_version }}_firefox
           path: |
             logs