-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for executeScript/evaluateScript args #826
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #826 +/- ##
============================================
- Coverage 98.47% 98.17% -0.30%
Complexity 345 345
============================================
Files 23 24 +1
Lines 983 986 +3
============================================
Hits 968 968
- Misses 15 18 +3
Continue to review full report at Codecov.
|
f49f3a1
to
d4424d1
Compare
Adding more parameters to the |
Yes, it is fatal error BC break - https://3v4l.org/kO2hW. I will create PRs to these drivers - https://github.com/minkphp/MinkSelenium2Driver and https://github.com/silverstripe/MinkFacebookWebDriver shortly. What are the other popular drivers? |
d4424d1
to
c5f9552
Compare
We simply cannot do such BC break in a minor version. That would mean we stop applying semver. |
c5f9552
to
b37c535
Compare
Are there any objections to release a v2? |
even for doing a v2, we would want to provide a migration path |
The args support is necessary as webdriver objects must be passed natively to the underlaying drivers & cannot be serialized directly into the 1st script argument.
Example
executeScript
method prototype of one of the most popular driver - https://github.com/php-webdriver/php-webdriver/blob/8ffa927b270e932449e8015abf4d38bb0eff24b7/lib/Remote/RemoteWebDriver.php#L324