Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add element attribute not exists #817

Merged

Conversation

murilohpucci
Copy link

Creating a pull request, if you have any questions, please let me know.

Thanks!

@murilohpucci murilohpucci force-pushed the feature/element-attribute-not-exists branch from dd3acdf to fd5c957 Compare December 7, 2021 18:58
@murilohpucci
Copy link
Author

Squashed the commits into one to follow the CONTRIBUTING.md specs.

tests/WebAssertTest.php Outdated Show resolved Hide resolved
@aik099 aik099 linked an issue Dec 8, 2021 that may be closed by this pull request
@murilohpucci murilohpucci force-pushed the feature/element-attribute-not-exists branch from 628dd9b to 72f3d25 Compare December 8, 2021 15:45
src/WebAssert.php Outdated Show resolved Hide resolved
@murilohpucci murilohpucci force-pushed the feature/element-attribute-not-exists branch from ed0131f to a27946b Compare December 8, 2021 17:52
@murilohpucci murilohpucci requested a review from aik099 December 8, 2021 18:15
Copy link
Member

@aik099 aik099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge.

@murilohpucci
Copy link
Author

That's awesome @aik099, thanks!

@stof stof merged commit 34c0ae0 into minkphp:master Dec 9, 2021
@murilohpucci murilohpucci deleted the feature/element-attribute-not-exists branch December 9, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Element attribute not exists
3 participants