-
Notifications
You must be signed in to change notification settings - Fork 280
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Session driver-independent way to make sessions unique.
- Loading branch information
Alexander Obuhovich
committed
Jun 6, 2013
1 parent
0afca9c
commit 953c8a8
Showing
2 changed files
with
35 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
953c8a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aik099 what was the goal of this
uniqueId
property ? It is not used anywhere in Mink or in related code I know of, and I don't understand its goal (and on the other hand, the unique id is not unique enough as I regularly get test failures because the same id is reused on Windows)953c8a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was created to be able distinct 2 Session class instances with identical drivers. It also was used during Session cloning.
Since all cloning related code was removed, then I guess we can safely remove this uniqueid stuff as well.
953c8a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the original PR where it was added: #348
953c8a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I suggest removing it before the 1.6 release
953c8a8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed.