Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documenting Gem update #797

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Documenting Gem update #797

merged 3 commits into from
Aug 29, 2024

Conversation

laurentb4
Copy link
Contributor

Added steps to README to upgrade a Gem in the Gemfile.

@laurentb4 laurentb4 requested a review from a team as a code owner August 9, 2024 07:23
@github-actions github-actions bot added documentation Improvements or additions to documentation dhcp-dns labels Aug 9, 2024
asifamirat00
asifamirat00 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@asifamirat00 asifamirat00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

smjmoj
smjmoj approved these changes Aug 13, 2024
View reviewed changes
Copy link

@smjmoj smjmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

asifamirat00
asifamirat00 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@asifamirat00 asifamirat00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurentb4 laurentb4 merged commit 7272789 into main Aug 29, 2024
@laurentb4 laurentb4 deleted the ND-454-documentation branch August 29, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asifamirat00 asifamirat00 asifamirat00 approved these changes

@smjmoj smjmoj smjmoj approved these changes

@dms1981 dms1981 Awaiting requested review from dms1981 dms1981 is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

@jamesgreen-moj jamesgreen-moj Awaiting requested review from jamesgreen-moj jamesgreen-moj is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

@sb21460 sb21460 Awaiting requested review from sb21460 sb21460 is a code owner automatically assigned from ministryofjustice/nvvs-devops-admins

Assignees
No one assigned
Labels
dhcp-dns documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurentb4 @smjmoj @asifamirat00