Logo update #764
Merged
Logo update #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated both the favicon and nav bar crown to show UK King Crown.
Currently this asset is not being used in the code anywhere so, we have removed it.
This condition never worked to begin with and was only used for IE8 copatability. Has been commented out on offical GovUK libary so following the library: alphagov/govuk-frontend@cf4790b
|
Obtained crown information from here: https://github.com/alphagov/govuk-frontend/blob/0b316d4306160c784a0c75cbdce5ee40ce[…]ackages/govuk-frontend/src/govuk/components/header/template.njk As this was hard coded, within our code base to begin with I have followed the pattern of leaving it hard coded and updating the code to follow new government standards. Rather than using the importing the library as this would be a bigger job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updated crown Queen to King.
Why
Screenshots
Notes
Please read commit messages.