Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature search function #753

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Feature search function #753

merged 2 commits into from
Nov 24, 2023

Conversation

juddin927
Copy link
Contributor

What

We are adding search function to the DHCP admin to search across Sites,Name and Subnet CIDR.

Why

As we prepare to onboard a substantial number of sites onto the MOJO DHCP service as part of the DHCP migration, navigating through DHCP sites and subnets within the ADMIN console poses a considerable challenge.

Notes

While the search function performs an exact match of the subnet CIDR, it lacks the capability to recognize subnetting and won't retrieve results if an IP address falls within a specific IP range.
in addition search feature queries using SQL queries which can be changed to use ransack

Screenshots

Screenshot 2023-11-23 at 12 38 29

…s against the Site Name,Fits_id and Subnet CIDR
@juddin927 juddin927 force-pushed the feature-serach-function branch from f50ce7d to a03be4b Compare November 23, 2023 12:47
Copy link

@smjmoj smjmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juddin927 juddin927 changed the title Feature serach function Feature search function Nov 24, 2023
@juddin927 juddin927 merged commit 0a10c7c into main Nov 24, 2023
@juddin927 juddin927 deleted the feature-serach-function branch November 24, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants